search

FinalsClub / karmaworld

KarmaNotes.org v3.0
GNU Affero General Public License v3.0
7 stars 6 forks source link

deploy note editing branch onto staging system #412

Closed btbonval closed 9 years ago

btbonval commented 9 years ago

tests for data on Beta can be found in this comment: https://github.com/FinalsClub/karmaworld/issues/396#issuecomment-75186537

btbonval commented 9 years ago

I think this shell wrapper does not close out celery properly. This is an argument for pursuing a single python for both celery worker and celery beat, as noted in this comment: https://github.com/FinalsClub/karmaworld/issues/407#issuecomment-75707833

I cannot seem to get this celerywrapper script to 100% of the time process added notes. Most of the time, I find it just runs through beat stuff and the worker does not process new notes, though I see the worker has clearly run.

btbonval commented 9 years ago

Running worker by itself is far more successful. Finally my uploaded notes are running again.

btbonval commented 9 years ago

Okay, bunch of tiny fixes implemented to get this ready for staging. Ran through a bunch of tests by hand and they passed. Cannot run proper tests because #311 is still an issue in my life.

Going to sit on this overnight and push to staging sometime on Friday.

btbonval commented 9 years ago

This branch has been prepared with a ton of fixes and master rebased in, tested, and ready for push to staging: https://github.com/FinalsClub/karmaworld/tree/note-editing-merge-more

btbonval commented 9 years ago

New error on the Heroku console:

-----> Noticed cffi. Bootstrapping libffi.
curl: /app/.heroku/vendor/lib/libsasl2.so.2: no version information available (required by /usr/lib/libldap_r-2.4.so.2)

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Exiting with failure status due to previous errors

 !     Push rejected, failed to compile Python app

To git@heroku.com:karmanotes-beta.git
 ! [remote rejected] note-editing-merge-more -> master (pre-receive hook declined)
error: failed to push some refs to 'git@heroku.com:karmanotes-beta.git'

I remember seeing this comment here to make buildpack install libffi https://github.com/FinalsClub/karmaworld/blob/note-editing-merge-more/requirements.txt#L25

It looks like that has been in place for ages. https://github.com/FinalsClub/karmaworld/commit/2d14f740692f1b61d7c3b7208c3a3bb0f5c18e9b

I had added cffi as an explicit requirement because I was version locking prereqs. Perhaps that threw something out of whack. I removed the line specifying cffi. It didn't help. https://github.com/FinalsClub/karmaworld/blob/note-editing-merge-more/requirements.txt#L1

Nothing changed in buildpack or upstream version of buildpack (or in upstream upstream version of buildpack).

btbonval commented 9 years ago

Ack, something changed out from under us. beta is currently running the master branch. I changed a file slightly (README.md) to trigger reloading the master branch on the beta. Same error using the code its already running.

The error has nothing to do with code we have changed. The buildpack doesn't seem to have changed.

So something is different with Heroku?

btbonval commented 9 years ago

Last successful deployment to beta appears to be 8 days ago.

The only news on the blog in the past nine days is one entry: https://blog.heroku.com/archives/2015/2/24/Heroku%20Connect%20Demo%20Edition%20Now%20Available%20via%20Heroku%20Button

It's just a new add-on.

btbonval commented 9 years ago

Spawning #417 to track libffi error

btbonval commented 9 years ago

Deployed to beta and Brown students are informed for their testing purposes. Let's wait and see what they say.

Branch deployed to beta is https://github.com/FinalsClub/karmaworld/tree/note-editing-merge-more

btbonval commented 9 years ago

Deployed to master a few days ago. This issue is completed.