FinalsClub / karmaworld

KarmaNotes.org v3.0
GNU Affero General Public License v3.0
7 stars 6 forks source link

pdf2htmlEX is not documented as a requirement/dependency #422

Closed btbonval closed 9 years ago

btbonval commented 9 years ago

but it is required for converting notes.

Here is the buildpack instructions to get it installed on Heroku, which is just a fancy way of downloading binary of it. https://github.com/FinalsClub/heroku-buildpack-karmanotes/blob/master/bin/steps/pdf2htmlex

Our fork, with its measly two lines changed to expose two functions, is severely behind upstream. https://github.com/FinalsClub/pdf2htmlEX

btbonval commented 9 years ago

The old Vagrantfile had a quick hack way to use the upstream PPA. https://github.com/FinalsClub/karmaworld/blob/cf1eddbf45804437ae824460079950918ce7ca1a/Vagrantfile#L66-L78

add-apt-repository ppa:coolwanglu/pdf2htmlex # pdf2htmlex
apt-get update
apt-get install pdf2htmlex
cat >> `dpkg -L pdf2htmlex | grep pdf2htmlEX.js` <<PDF2HTMLEXHACK
Viewer.prototype['rescale'] = Viewer.prototype.rescale;
Viewer.prototype['scroll_to'] = Viewer.prototype.scroll_to;
PDF2HTMLEXHACK