tags operate differently if using edit this note or edit tags

[btbonval]

edit this note dialog is tied to note editing logic, and does not discriminate if the name, the tags, or the body was changed. The whole form is all-or-nothing POST. The delete button logic is handled separately, but it only shows up in the edit this note dialog.

edit tags button only allows editing of tags, and does so through AJAX.

This becomes a problem because tags are editable even if a note is not, and that logic is tied to the AJAX call. The POST call for the edit form only considers the body + name, using a different logic.

Here's my suggestion:

• remove the tags from edit this note so that redundancy is gone and so that tags will always be handled the same way.
• move the delete button out of edit this note and make it its own button so it will always be accessible to note owners.
• only show edit this note when the note is editable (tags are editable + note is editable)
• only show edit tags when tags are editable (note is deletable + 20 points)
• only show delete this note when the note is owned by the user or user is admin

The logic is already done for the last three, it just needs to be sanely woven into the UI.

[btbonval]

delete button is hard to manage. it sort of changes the flow, but I think I'm going to leave it as is. I'm not a UI designer and it functions.

NOTE NAME
[BIG RED DELETE NOTE BUTTON]

[thanks] [report] [download] [edit tag] [edit note]

[btbonval]

beautiful. disabled, but did not hide, the buttons that will not have any effect. should support the effort of #418 as well

[btbonval]

this was resolved in the commit linked above.