search

FinalsClub / karmaworld

KarmaNotes.org v3.0
GNU Affero General Public License v3.0
7 stars 6 forks source link

static file hosting locally is not documented #441

Closed btbonval closed 9 years ago

btbonval commented 9 years ago

It might be the case that the software comes out of the box ready to go for static file hosting without AWS S3.

However, if this is the case, it should be made explicit.

btbonval commented 9 years ago

The dev.py pathway supports local static storage. https://github.com/FinalsClub/karmaworld/blob/f8a5b8e24fe4751b9d22d121b152fb14e9f78932/karmaworld/settings/dev.py#L27-L33

The default .env.example is configured to read from dev.py: https://github.com/FinalsClub/karmaworld/blob/048451fb4470fa271750619e0c98b085465a38cc/.env.example#L29-L30

However .env.example also has DEFAULT_FILE_STORAGE set to S3, which would be confusing given that it is ignored entirely from dev.py but utilized in prod.py.

Perhaps the .env.example should have those lines commented out for consistency with the dev-as-default scenario.