Origami - Githubissues

Financial-Times / ftdomdelegate

Create and manage a DOM event delegator

MIT License

320 stars 36 forks source link

Origami #48

Closed wheresrhys closed 10 years ago

wheresrhys commented 10 years ago

Closes https://github.com/ftlabs/ftdomdelegate/issues/43

wheresrhys commented 10 years ago

Should this even have an origami.json though? It's definitely not origami compliant (even if the code is, it still fails to conform to naming conventions)

matthew-andrews commented 10 years ago

Could I request a couple of changes:-

Can we remove the EventListener polyfill from the repo? (It doesn't have a license - I've requested they add one)
Where did the matches polyfill come from? Have we checked that we're OK to copy it into the repo? Should we link to where it was?

(I also just change ie8 in the README to be 'Internet Explorer 8' to be consistent with the text above)

wheresrhys commented 10 years ago

I've replaced with references (commented out for normal use) to the raw files on github/cdn

I also replaced the bower.json name 'dom-delegate' with 'ftdomdelegate'. I spoke to Andrew about this last week and the official entry on the bower registry should be updated too (or another one added under the ftdomdelegate name)

matthew-andrews commented 10 years ago

I also replaced the bower.json name 'dom-delegate' with 'ftdomdelegate'. I spoke to Andrew about this last week and the official entry on the bower registry should be updated too (or another one added under the ftdomdelegate name)

I don't think we should do that... we have real people using this repository. Can we undo this for now and create a ticket to discuss our options?

wheresrhys commented 10 years ago

I don't think it'll break anything for them though (if you add a new one with the name ftdomdelegate and keep the old one that is). It will probably emit a warning on bower install.

... too many 'probably's in that wasn't there - I'll revert for now.

matthew-andrews commented 10 years ago

As per @triblondon's response - let's remove the origami.json. This falls under the same category as lodash, etc.

triblondon commented 10 years ago

What's the status of this? I believe @wheresrhys has dropped IE8 to core experience for Fast FT so no longer requires domdelegate. @matthew-andrews do you think it's worth finishing this off and getting basic IE8 support anyway?

wheresrhys commented 10 years ago

I think it's still well worth merging it.