search

Financial-Times / ftdomdelegate

Create and manage a DOM event delegator
MIT License
320 stars 36 forks source link

Call it ftdomdelegate #93

Closed i-like-robots closed 5 years ago

i-like-robots commented 5 years ago

We're having some problems with tools resolving this module because it is still named dom-delegate in the manifest files. Insofar as I can tell we mostly refer to this module as ftdomdelegate in our code on FT.com, Origami components, and across the organisation.

The package is currently named ftdomdelegate only in the Origami registry. It is named dom-delegate on the Bower and npm registries.

I am proposing changing the package name to ftdomdelegate to match our code as this is what I have visibility over and most care about. This will require a major version bump and publishing to npm and Bower.

So, shall we finally get it over with? (2015 was a long time ago! #75)

apaleslimghost commented 5 years ago

'build/dom-delegate.js' matched no files or resources

womp womp https://github.com/Financial-Times/ftdomdelegate/blob/master/GruntFile.js#L12

i-like-robots commented 5 years ago

That's fun, neither bower.main nor pkg.main referencedom-delegate.js

apaleslimghost commented 5 years ago

looks like it's from https://github.com/Financial-Times/ftdomdelegate/blob/5283ab9b1980c277225d69c127257c1d4781024d/test/buster.js#L13?

apaleslimghost commented 5 years ago

(see also #75, #77, #88, bower/bower#2135)