search

Financial-Times / ftdomdelegate

Create and manage a DOM event delegator
MIT License
320 stars 36 forks source link

Keep package.json on bower install. #96

Closed notlee closed 5 years ago

notlee commented 5 years ago

When running Jest tests, Scout Asia rely on a component's package.json to resolve Origami components which were installed via Bower.

In v3 package.json was added to Bower's ignore property, which means their tests now fail. They required v3 without taking action because it's included in other components such as o-tooltip using a range https://github.com/Financial-Times/o-tooltip/pull/71. We use a range as the interface of v3 is the same as v2 -- we just removed the dom-delegate alias.

notlee commented 5 years ago

I'm going to suggest they move to use Origami over npm instead of bower, but this should fix their immediate issue.