Add change api to n-gage

Financial-Times / n-gage

Shared developer and build tools for FT.com applications and components

9 stars 3 forks source link

Add change api to n-gage #202

Closed ericanand closed 5 years ago

ericanand commented 5 years ago

Why

A simple curl request which fires off at the end of the deploy step.

Currently would send a release log to #ft-changes, though if we wanted to add a slack channel for this we could do that too. The release log would be useful for audit/logging purposes.

What's Changed

Added the api request to the end of the deploy command. This would not affect deployment of an app if it failed.

Notes

Need to decide whether this lives in the deploy job. Would prefer for this to be a separate make command, however we would then need to change a lot of repos to add this in 🙈.

apaleslimghost commented 5 years ago

nice! there is one problem with having it in deploy: apps with canaries (router, preflight & api) don't use that task, but deploy-canary and deploy-production instead.

you could pull it out into a separate task, and at the end of each of the deploy commands add $(MAKE) change-api

ericanand commented 5 years ago

Ah sweet! Thanks will do that :)

ericanand commented 5 years ago

Happy to beta test this along with someone if they have time too.

sjparkinson commented 5 years ago

@ericanand mind documenting the release process for this change as a comment on this PR?

Currently would send a release log to #ft-changes, though if we wanted to add a slack channel for this we could do that too.

Let's start with the shared channel and see how it goes. We already have notifications in #ft-next-releases that comes in via the next-webhooks system, but we could/should look to get rid of that and use this shared tooling.

ericanand commented 5 years ago

Haha, I don't fully know the proper process on how to roll this out! However I gathered it would be:

Merge into master when everyone is happy
Make a tagged github release using a beta (Eg: v3.8.0-beta.1)/ pre-release tag so it doesn't get pulled in by other projects (correct me if I'm wrong).
Test deployment on projects (not sure which) to see if the change works as expected.

Could use a pair (as mentioned before) to help me through the last 2 steps so I don't do something stupid! Also there may be something else you do for your releases which I'm missing 🤷‍♂.