Quote PATH variable to prevent space splitting

Financial-Times / n-gage

Shared developer and build tools for FT.com applications and components

9 stars 3 forks source link

Quote PATH variable to prevent space splitting #226

Closed vtenfys closed 4 years ago

vtenfys commented 4 years ago

Previously this was causing issues for people with spaces in their PATH directories

See also #224

vtenfys commented 4 years ago

Failed twice at Bower 🤔 Going to have a look to see what's causing that

vtenfys commented 4 years ago

Sooo apparently this causes it to be double quoted on Linux, at least I believe that's why tests are failing on Circle since echo $PATH produces the same output either way

Hopefully it'll work if I put the quotes around the export PATH line instead of the shell one

vtenfys commented 4 years ago

Hopefully it'll work if I put the quotes around the export PATH line instead of the shell one

nope 😭

vtenfys commented 4 years ago

Needed to quote around the whole PATH=$(PATH), now it should pass on CI!