Open wheresrhys opened 7 years ago
So that the failure of any subpart of the service worker doesn't mean the entire thing needs to be turned off, each feature should be gated by a feature flag. Feature flags are updated on every page load https://github.com/Financial-Times/n-service-worker/blob/master/src/utils/flags.js and then used elsewhere to disable/enable features e.g. https://github.com/Financial-Times/n-service-worker/blob/master/src/utils/handlers.js#L68
There needs to be a flag which can be used to turn off the offline bit of the service worker while keeping the other bits running
So that the failure of any subpart of the service worker doesn't mean the entire thing needs to be turned off, each feature should be gated by a feature flag. Feature flags are updated on every page load https://github.com/Financial-Times/n-service-worker/blob/master/src/utils/flags.js and then used elsewhere to disable/enable features e.g. https://github.com/Financial-Times/n-service-worker/blob/master/src/utils/handlers.js#L68
There needs to be a flag which can be used to turn off the offline bit of the service worker while keeping the other bits running