search

Financial-Times / n-test

A CLI tool and module for lightweight testing of web applications in browsers, designed for FT.com
4 stars 2 forks source link

Add timeout to webdriver page load if intended waitFor event not default #122

Closed maxcbc closed 5 years ago

maxcbc commented 5 years ago

Add timeout to webdriver page load if intended waitFor event not default

This is to make up for the fact that chrome pages can wait for 'load' events while non-chrome can't.

simonplend commented 5 years ago

@ker-an Max is on the case of flakey smoke tests!

ker-an commented 5 years ago

@maxcbc you are my hero 🥇

simonplend commented 5 years ago

@maxcbc Can this PR be closed in favour of https://github.com/Financial-Times/n-test/pull/125?