search

Financial-Times / n-test

A CLI tool and module for lightweight testing of web applications in browsers, designed for FT.com
4 stars 2 forks source link

Update webdriver page to use 'waitUntil' #125

Closed maxcbc closed 5 years ago

maxcbc commented 5 years ago

Update webdriver page to use 'waitUntil' if pageOptions.waituntil is anything other than 'domcontentloaded'.

This is to make up for the fact that we wait for dom events such as load to be fired on puppeteer but not on webdriver (i.e. non-chromium)

🐿 v2.12.4

simonplend commented 5 years ago

Looks good - fingers crossed this improves the stability of our smoke tests :crossed_fingers: