search

Financial-Times / n-test

A CLI tool and module for lightweight testing of web applications in browsers, designed for FT.com
4 stars 2 forks source link

Fix issues with engines enforcement #181

Closed ivomurrell closed 3 years ago

ivomurrell commented 3 years ago

Two changes to enforcing the right version of node and npm with check-engines:

  1. Improve compatibility of check-engines guard: some shells in use (particularly in our CI and build images) do not support the non-POSIX [[ command, so use the more portable [ built-in instead.
  2. Allow npm 8: the only breaking change in npm8 is dropping support for node<12, but we already require node@12 so this doesn't affect us and will allow for newer npm versions to be used.