Financial-Times / n-test

A CLI tool and module for lightweight testing of web applications in browsers, designed for FT.com
4 stars 2 forks source link

Fix typo in preinstall script dependency #186

Closed ivomurrell closed 2 years ago

ivomurrell commented 2 years ago

We use the check-engine script to enforce the versions defined in the package.jsons engines field. Unfortunately, instead of installing check-engine in our devDependencies we instead were installing check-engines (note the plural) errorneously. Because we're running check-engine before the dependencies are actually installed – the first time at least – we override npm 7's prompt to confirm installing a new package and so this typo was missed. check-engines was never actually run, nor does it look like a security threat, so we don't need to do anything else, we just want to make sure we are using the correct major version of check-engine to avoid breaking changes in the future.