search

Financial-Times / n-ui

❌ DEPRECATED Server, build and client side bootstrapping for FT.com's user-facing applications.
7 stars 5 forks source link

Origami major cascade #1514

Closed i-like-robots closed 4 years ago

i-like-robots commented 4 years ago

Updates all Origami and n- dependencies to their latest major versions.

chee commented 4 years ago

does this PR also remove krux?

andrewgeorgiou1981 commented 4 years ago

does this PR also remove krux?

This PR removes the bulk of krux code - some krux code was still around as it was being re-used by permutive which is the replacement for Krux (There was a branch to completely remove all krux code; however this caused various issues in the past so we made a decision to leave n-ui as-is and make sure that pageKit/n-ads is completly clean of all krux code). Bumping o-ads has forced us to remove the majority of krux code though as o-ads v13 and above is not compatible with krux functionality. I have made a new release of o-ads v14.1.0 which is backwards compatible with how n-ui gets page and user-meta data and passes it to permutive and does not require any of the n-ui functionality previously name-spaced under 'krux'.