Financial-Times / n-ui

❌ DEPRECATED Server, build and client side bootstrapping for FT.com's user-facing applications.
7 stars 5 forks source link

Disable GTM for pa11y tests #1529

Closed carlesandres closed 4 years ago

carlesandres commented 4 years ago

Adding the floodlight tag via Google Tag Manager makes a couple of Pa11y test fail (see this)

The same way we did for next-subscribe , we are now instructing ignoring Pa11y to not look at Doubleclick iframes.

Since ☝️ this doesn't seem to sort out the problem completely, I'm also (temporarily) disabling GTM altogether during pa11y tests the same way we already disable ads. This obviously introduces some blind spots in our a11y testing but I believe this is acceptable for now as n-ui is being phased out. However, I plan to discuss with the a11y team asap to come up with a better solution.