search

Financial-Times / nori

🍙 exploratory command-line tool to make changes across multiple repositories & track their progress
MIT License
11 stars 0 forks source link

State is not saved on error #148

Open ivomurrell opened 3 years ago

ivomurrell commented 3 years ago

If you get an error when running an operation for a repository the operation will continue to execute until all repositories have either succeeded or failed. However, currently when a repository does fail the repositories that did succeed are not stored in the state, making it very hard to track which repos are safe to rerun if an operation isn't idempotent. We should look into improving interaction with immer to ensure that the mutated state is stored even if an error is thrown.

We could potentially use createDraft and finishDraft to properly handle immer drafts within a try/catch block.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.