search

Financial-Times / nori

🍙 exploratory command-line tool to make changes across multiple repositories & track their progress
MIT License
11 stars 0 forks source link

feat: add @octokit/plugin-throttling and @octokit/plugin-retry #69

Closed sjparkinson closed 5 years ago

sjparkinson commented 5 years ago

This will help us in avoiding the abuse rate limits when opening many pull requests at once.

sjparkinson commented 5 years ago

Two errors in the test suite to be addressed.

 FAIL  test/commands/project.test.js
  ● Test suite failed to run

    TypeError: require(...).plugin is not a function

      1 | const Octokit = require('@octokit/rest')
    > 2 |   .plugin(require('@octokit/plugin-throttling'))
        |    ^
      3 |   .plugin(require('@octokit/plugin-retry'));
      4 | 
      5 | let client;

      at Object.plugin (src/lib/octokit.js:2:3)
      at Object.require (src/commands/project.js:1:20)
apaleslimghost commented 5 years ago

you'll want to add a module.exports.plugin = () => module.exports or something to the Octokit mock

sjparkinson commented 5 years ago

Ah awesome, thanks! Was hitting a wall with it 😂