search

Financial-Times / nori

🍙 exploratory command-line tool to make changes across multiple repositories & track their progress
MIT License
11 stars 0 forks source link

PR entry returns true if title provided #83

Closed jenniferemshepherd closed 5 years ago

jenniferemshepherd commented 5 years ago

Fixes #78. If a title for a PR is provided, then we want to return true so that enquirer doesnt kick up a fuss and we can run nori on 70 repos thanks.

jenniferemshepherd commented 5 years ago

FYI this is the error that led to the 2nd commit:

Error: octokit/plugin-throttling error:
        You must pass the onAbuseLimit and onRateLimit error handlers.
        See https://github.com/octokit/rest.js#throttling

        const octokit = new Octokit({
          throttle: {
            onAbuseLimit: (error, options) => {/* ... */},
            onRateLimit: (error, options) => {/* ... */}
          }
        })

    at throttlingPlugin (/Users/jennifer.shepherd/FT/Customer_Products/ETG/nori/node_modules/@octokit/plugin-throttling/lib/index.js:62:11)
    at Octokit.plugins.forEach.pluginFunction (/Users/jennifer.shepherd/FT/Customer_Products/ETG/nori/node_modules/@octokit/rest/lib/constructor.js:24:37)
    at Array.forEach (<anonymous>)
    at new Octokit (/Users/jennifer.shepherd/FT/Customer_Products/ETG/nori/node_modules/@octokit/rest/lib/constructor.js:24:11)
    at module.exports.token (/Users/jennifer.shepherd/FT/Customer_Products/ETG/nori/src/lib/octokit.js:9:12)
    at Promise.all.branches.map (/Users/jennifer.shepherd/FT/Customer_Products/ETG/nori/src/commands/prs.js:31:10)
    at Array.map (<anonymous>)
    at Object.exports.handler (/Users/jennifer.shepherd/FT/Customer_Products/ETG/nori/src/commands/prs.js:29:30)
    at runStep (/Users/jennifer.shepherd/FT/Customer_Products/ETG/nori/src/interactive.js:121:35)
    at Object.exports.handler (/Users/jennifer.shepherd/FT/Customer_Products/ETG/nori/src/interactive.js:197:10)