search

Financial-Times / nori

🍙 exploratory command-line tool to make changes across multiple repositories & track their progress
MIT License
11 stars 0 forks source link

Pasting a carriage return in the body of a PR ignores body #89

Closed taktran closed 5 years ago

taktran commented 5 years ago

When you paste body content in the PR step with a carriage return, nori creates the PR with an empty body and ignores what was pasted.

To replicate:

  1. Get to the PR step in nori
  2. Create a title
  3. Paste the following into body:
Some message

Another thing
  1. PR will be created, but body will be missing
taktran commented 5 years ago

Current hack is to use <br/><br/> to create spaces in markdown eg, https://github.com/Financial-Times/app-push-notifications/pull/31

taktran commented 5 years ago

Seems like an issue with how enquirer handles input. It thinks the newlines are submit events.

There is an issue that seems to say multiline input is supported, but I haven't been able to get it to work. I've added a comment to the issue https://github.com/enquirer/enquirer/issues/27#issuecomment-497774599

Update: A new issue here: https://github.com/enquirer/enquirer/issues/164

apaleslimghost commented 5 years ago

since this is an enquirer bug, we should use their issue to track it, and hopefully fix it ourselves there