After discussion with Andrew, we agreed that cypress and pupeteer tests are doing the same thing as what is now tested with titella. These tests were also not as accurate as titella, as they are testing demo pages which can get out of date and are not as accurate as testing the live site. Testing is dead. Long live testing (through titella)
Also removing nightwatch tests, as we agreed these don't add much value (we are just rendering a couple of divs!). o-ads is going into maintenance mode. The tests currently pass and we are not making any more active changes to the repo. Similarly the nightwatch config uses fixed versions for browsers so it will not catch any errors on new browser releases (which is also very unlikely).
The tests haven't been removed so that if a cross browser bug crops up in the future for example, we can still run them to help us debug a problem. I've just removed them from the CI build.
This makes the build green and 3 x faster so that we can move rapidly with any urgent fixes that might be needed in the future
alexflorisca
commented
3 years ago
Because why not?
Just kidding.
After discussion with Andrew, we agreed that cypress and pupeteer tests are doing the same thing as what is now tested with titella. These tests were also not as accurate as titella, as they are testing demo pages which can get out of date and are not as accurate as testing the live site. Testing is dead. Long live testing (through titella)
Also removing nightwatch tests, as we agreed these don't add much value (we are just rendering a couple of divs!). o-ads is going into maintenance mode. The tests currently pass and we are not making any more active changes to the repo. Similarly the nightwatch config uses fixed versions for browsers so it will not catch any errors on new browser releases (which is also very unlikely).
The tests haven't been removed so that if a cross browser bug crops up in the future for example, we can still run them to help us debug a problem. I've just removed them from the CI build.
This makes the build green and 3 x faster so that we can move rapidly with any urgent fixes that might be needed in the future