search

Financial-Times / o-grid

Responsive grid system
http://registry.origami.ft.com/components/o-grid
93 stars 14 forks source link

Gutterless columns feature not working #1

Closed wheresrhys closed 11 years ago

wheresrhys commented 11 years ago

This may not be a bug, but in bootstrap, columns have much more spacing between them by default. The switch to ft-grid is quite evident in the change in the origami docs when you look at the sidebar. This gap used to be about 3x wider: pastedgraphic-1 Is the grid spacing a grid module concern? If so, is it currently a bit tight, do you think? @triblondon

wheresrhys commented 11 years ago

Short of the designers asking for wider gutters I don't think we can change this. There could be a case for adding a fat-gutters mode for the grid, or maybe making the gutters use percentage rather than fixed values, though both would be enemies of consistency. Over-riding the gutters to make them wider by just over-writing in origami's css is easy enough, but don't know if it's something we want to encourage in one of our our first proofs of concept?

@pauloneillft - could you take a look and bring it up with other designers as you think fit.

manalishi79 commented 11 years ago

Design feedback: Gaps should be 20px

wheresrhys commented 11 years ago

The gutterless columns feature I added doesn't work as intended, so I've stopped using it on origami for the time being and will either remove or fix in the next release of grid-module. I only added it because Origami's nav was flush to the left of the screen and was trying to replicate as closely as possible, but not sure if it's a required feature for FT.