Closed kaelig closed 8 years ago
This is now done. I'm going to close this, but I'll keep the branch open in case anyone else wants to give it a go.Though do checkout the commit Kaelig made!
Well done! Did it help you understand the code base better?
Yeah, it was pretty good, thanks for that!
Because o-grid is pretty complex, I built an exercise for you @AlbertoElias, so that you can understand the code and tests.
At the moment, outer margins (space on the left and right of a o-grid-container) are the same as gutters: 10px < M, and 20px on layouts >= M.
It works exactly like for gutters.
This branch contains a few tests. To make them pass here is what is needed:
$o-grid-outer-margins
map that contains outer margins for each breakpointmodify the mixin
oGridAddLayout
so that developers can add a layout with a specific$outer-margin-width
:oGrid.getCurrentOuterMargin
JS helper functionps: not sure that should be merged when you're done, since it's not something anybody needed. But after doing this exercise you should know all the secrets behind the grid!