Financial-Times / o-grid

Responsive grid system
http://registry.origami.ft.com/components/o-grid
94 stars 17 forks source link

[do not merge] Exercise: add outer margins #107

Closed kaelig closed 8 years ago

kaelig commented 9 years ago

Because o-grid is pretty complex, I built an exercise for you @AlbertoElias, so that you can understand the code and tests.

At the moment, outer margins (space on the left and right of a o-grid-container) are the same as gutters: 10px < M, and 20px on layouts >= M.

It works exactly like for gutters.

This branch contains a few tests. To make them pass here is what is needed:

ps: not sure that should be merged when you're done, since it's not something anybody needed. But after doing this exercise you should know all the secrets behind the grid!

AlbertoElias commented 8 years ago

This is now done. I'm going to close this, but I'll keep the branch open in case anyone else wants to give it a go.Though do checkout the commit Kaelig made!

kaelig commented 8 years ago

Well done! Did it help you understand the code base better?

AlbertoElias commented 8 years ago

Yeah, it was pretty good, thanks for that!