search

Financial-Times / o-grid

Responsive grid system
http://registry.origami.ft.com/components/o-grid
93 stars 14 forks source link

Variable naming conventions #11

Closed wheresrhys closed 11 years ago

wheresrhys commented 11 years ago

In color-module, the vars are camel case, e.g. $ftColor-Pink. Yours are lower case with dashes. Can we agree a standard and change one or the other? @triblondon

wheresrhys commented 11 years ago

I did have camel case but found hyphenation to be far more readable & harmonious with the CSS so switched. So hyphenation gets my vote, with camel case for mixins and functions (because hyphenation can cause annoying behaviour sometimes).

triblondon commented 11 years ago

OK, hypenation it is. Will open an issue in colours to change that, and add a rule to Origami.