search

Financial-Times / o-grid

Responsive grid system
http://registry.origami.ft.com/components/o-grid
93 stars 14 forks source link

Put flex related autoprefixer off in own block #115

Closed ironsidevsquincy closed 8 years ago

ironsidevsquincy commented 8 years ago

As the autoprefixer comment applies to the whole block it's in

cc: @wheresrhys, @AlbertoElias

AlbertoElias commented 8 years ago

But what about the autoprefixer on comment?

ironsidevsquincy commented 8 years ago

We don't need to turn it on, we want it off within the block

AlbertoElias commented 8 years ago

But there's a comment that turns it off, and another that turns it on. Isn't that the same as turning it off in another block?

This email was sent by a company owned by Financial Times Group Limited ("FT Group http://aboutus.ft.com/corporate-information/#axzz3rajCSIAt"), registered office at Number One Southwark Bridge, London SE1 9HL.
Registered in England and Wales with company number 879531. This e-mail may contain confidential information. If you are not the intended recipient, please notify the sender immediately, delete all copies and do not distribute it further. It could also contain personal views which are not necessarily those of the FT Group. We may monitor outgoing or incoming emails as permitted by law.

ironsidevsquincy commented 8 years ago

No. It's rather misleading, you can't turn it back on in the same block, and turning it off applies to the whole block, even to the properties set before turning it off - https://github.com/postcss/autoprefixer#disabling

AlbertoElias commented 8 years ago

This was obviously fine to merge into master, but we need to be careful with these things and we prefer prs to be approved before merging

ironsidevsquincy commented 8 years ago

No problem. This was a major bug effecting all IEs plus others in prod, so needed to get it out pronto

AlbertoElias commented 8 years ago

I understand, just ping us on Slack mentioning the urgency