Financial-Times / o-grid

Responsive grid system
http://registry.origami.ft.com/components/o-grid
93 stars 14 forks source link

Remove Travis, add Circle, remove html files & modify origami.json #128

Closed j-mes closed 8 years ago

j-mes commented 8 years ago

@AlbertoElias could you please check this branch with OBT --runServer? It complained about some Sass errors and would not run. I'm not sure whenever I should remove/correct those errors or not.

FYI: After investigation with @onishiweb, there was a map being put inside a string which caused errors with linting and in turn preventing from the demos being run. Changed from #{$o-grid-gutters} to 5px in place instead.

j-mes commented 8 years ago

See updated pull request comment with Sass errors in resized.scss

kaelig commented 8 years ago

I believe the test demo is the only one that needs to load the JS (style-switcher).

j-mes commented 8 years ago

This has been amended and I have tried the test.html to see if it would switch between all the versions of the o-grid.

I have asked @AlbertoElias to give this a once-over to make sure all is good.