search

Financial-Times / o-grid

Responsive grid system
http://registry.origami.ft.com/components/o-grid
94 stars 17 forks source link

Support disabling 'nice to have' features #131

Closed wheresrhys closed 6 years ago

wheresrhys commented 8 years ago

Pull and push state and human friendly classes add a lot to the file size but are either just syntactic sugar or cover pretty uncommon cases. It'd be nice to be able to turn them off via a mechanism similar to silent mode:

$o-grid-output-human-friendly-classes: true !default;
$o-grid-output-pull-push-classes: true !default;
wheresrhys commented 8 years ago

https://github.com/Financial-Times/o-grid/pull/132

wheresrhys commented 8 years ago

As an addendum to this issue, the hide keyword is bundled in with the human-friendly classes, but unlike those, it is not just an alias to some number as 0 is not supported as a column width. I suggest either 0 should be supported or hide shoudl not be bundled in the human-friendly mixin

gvonkoss commented 6 years ago

Closing as it has been done https://github.com/Financial-Times/o-grid/pull/136, and is being replaced with more relevant: https://github.com/Financial-Times/o-grid/issues/157