search

Financial-Times / o-grid

Responsive grid system
http://registry.origami.ft.com/components/o-grid
94 stars 17 forks source link

Why suggest disabling user scaling? #19

Closed matthew-andrews closed 10 years ago

matthew-andrews commented 10 years ago

The README located here http://git.svc.ft.com/summary/origami%2Fo-grid.git says:

If your entire page is to be laid out using the grid add the class o-grid-page to the body/ wrapper and then build up the layout using nested rows and columns. The html head must include the following metatag (or equivalent) to disable user scaling

<meta name="viewport" content="initial-scale=1.0, maximum-scale=1.0, user-scalable=0">

Why does it need to disable scaling? For FastClick we recommend the following viewport tag:-

<meta name="viewport" content="width=device-width, initial-scale=1">

People like to pinch zoom and get quite vocal when they can't...

triblondon commented 10 years ago

Agree, it's definitely not right to disable user scaling.

wheresrhys commented 10 years ago

I'm fairly sure the grid misbehaved on some devices without user-scalable=0. I'll re-investigate before releasing the next patch. The main problem is with being able to zoom out (some browsers in that scenario choose to view the large screen layout at a tiny scale), but maybe we coudl go with minimum-scale=1

wheresrhys commented 10 years ago

Can't find any device where the FT-labs approach breaks so will make the change

matthew-andrews commented 10 years ago

Can we keep the issue open until the fix has been merged?

matthew-andrews commented 10 years ago

Ok I've just seen this has been fixed.