Normalise usage of class="o-grid-row" & data-o-grid-colspan="12"

kaelig commented 9 years ago

Currently it's possible to combine class="o-grid-row" and data-o-grid-colspan to create a single full width container, such as:

<!-- Full width, horizontally centred container, with proper outer margins -->
<div class="o-grid-row" data-o-grid-colspan="12"></div>

It ties the two constructs together: an issue for maintainability
works only when the value of data-o-grid-colspan is 12 (any other value won't have the desired effect): creates an undesirable edge case in the API

We should normalise the usage and allow only one, nested notation, similar to any other way you'd add columns in a row:

<div class="o-grid-row">
     <div data-o-grid-colspan="12"></div>
</div>

triblondon commented 9 years ago

No objection.

kaelig commented 9 years ago

Closing as this is in v3.

A few modules need to be tweaked:

Financial-Times / o-grid