Financial-Times / o-grid

Responsive grid system
http://registry.origami.ft.com/components/o-grid
94 stars 17 forks source link

Remove support for a single column "core experience" #69

Closed kaelig closed 9 years ago

kaelig commented 9 years ago

The core experience was supposed to be a single column layout, without any floats, which is impractical for development since it forces the use of hacks targeting modern browsers and IE8 only to serve any layout rule.

Since we don't support IE7 and really old browsers anyway (even version 2 of o-grid isn't , I suggest we simplify o-grid.

Changes

kaelig commented 9 years ago

@wheresrhys It'd be great if you could have a read. Let me know if that's something that makes sense or not.

triblondon commented 9 years ago

Core/enhanced is a Javascript thing, in my view, not something we've ever applied to CSS. I'm happy with rendering errors creeping into layouts in older browsers as long as the content is still readable.

We effectively have a CTM for CSS by using media queries, which give us a baseline for anything we 'guard' inside a query. We should make sure we're on the same page on this - I think currently when we talk about core experience in relation to things other than JavaScript we have quite different ideas of what that means.

It's actually hard to use the same core/enhanced boundary for CSS as JS, unless we did something like loading a different stylesheet based on the result of the CTM test - I'm open to that idea but I think it would hurt performance too much.

wheresrhys commented 9 years ago

use browsers hacks in the product stylesheets

Maybe point out that a box-sizing polyfill will help.

Otherwise I don't have a strong opinion, other than that code simplicity is good

kaelig commented 9 years ago

@wheresrhys Good idea, thanks.