search

Financial-Times / o-grid

Responsive grid system
http://registry.origami.ft.com/components/o-grid
93 stars 14 forks source link

Add display:block to o-grid-row #72

Closed wheresrhys closed 9 years ago

wheresrhys commented 9 years ago

I would do PR, but I imagine there'd be places where display:block needs to be carefully unset.

The use case is for using <a> tags as rows so that in next we can turn entire cards into links

kaelig commented 9 years ago

Sounds sensible, can you test it in next and make a PR for it?

kaelig commented 9 years ago

@wheresrhys any news on adding display: block to o-grid-row? Have you tested it on Next?

wheresrhys commented 9 years ago

ended up not turning entire cards into links so untested, but still seems like a sensible idea. A non display:block row doesn't make much sese

kaelig commented 9 years ago

Aren't you afraid it would add a lot of display: block in the codebase and the module itself for a small subset of uses?

kaelig commented 9 years ago

Closing this as it hasn't come up recently. Please reopen if you see a use case that would justify adding display: block to grid rows.