search

Financial-Times / o-grid

Responsive grid system
http://registry.origami.ft.com/components/o-grid
94 stars 17 forks source link

Don't always try and recalc whether we're in IE8 #73

Closed samgiles closed 9 years ago

samgiles commented 9 years ago

It's very unlikely to change once it's been calculated once, (although it will get calc'd on each 'require').

I noticed this was adding to the scroll jank using chrome 41 in o-techdocs, see: https://github.com/Financial-Times/o-techdocs/blob/master/src/js/nav.js#L46.

screen shot 2015-03-10 at 19 29 08

kaelig commented 9 years ago

Good one. Have you tested in IE8?

samgiles commented 9 years ago

Ah no, I didn't have an 'in date' VM with it installed. Will try and get round to it.

samgiles commented 9 years ago

Have now tested in IE8! It works. :)

kaelig commented 9 years ago

Cheers Sam, well done!