search

Financial-Times / o-grid

Responsive grid system
http://registry.origami.ft.com/components/o-grid
94 stars 17 forks source link

Add automated tests and fix various syntax errors #96

Closed kaelig closed 9 years ago

kaelig commented 9 years ago

Note that these tests allowed me to discover some edge cases with oGridAddLayout that I've also fixed in this PR.

AlbertoElias commented 9 years ago

Looks good, but why add the tests in Ruby? You can do all that in Node as well and it's more consistent with other tests. Or is that something that's not too important?

kaelig commented 9 years ago

Good question, thanks. I simply copied the existing o-colors tests.

Should we write everything in JS?

AlbertoElias commented 9 years ago

I think so, we've been trying to remove the Ruby dependency for things, although we still have Scss-Lint, so having it in tests isn't very helpful for that