Icons in use in next - Githubissues

Financial-Times / o-icons

Icons for FT sites. http://registry.origami.ft.com/components/o-icons

4 stars 4 forks source link

Icons in use in next #11

Closed wheresrhys closed 8 years ago

wheresrhys commented 8 years ago

The following icons are in use in next and need importing to o-icons so we can deprecate the nextIcon mixin. Can those I've assigned below please work with the origami team to provide copies of the SVGs etc.

[x] gift @bjfletcher (https://github.com/Financial-Times/n-email-article/pull/11)
[x] Various publication-type icons @lc512k @ifyio @tavvy (https://github.com/Financial-Times/n-barriers/pull/9)
[x] video @i-like-robots (https://github.com/Financial-Times/n-card/pull/94)
[x] [star hollow] https://github.com/Financial-Times/n-message-prompts/blob/ce939d9577283b3c9a8ab91e0ea4d8080d32a233/src/prompts/styles/promo-unit.scss#L289 @ifyio - https://github.com/Financial-Times/n-message-prompts/pull/90
[x] brand-ft-masthead, myft-bolder, brand-ft, brand-fast https://github.com/Financial-Times/next-front-page/blob/5072415def21f7114fcdd9d2e18c8420d9e103df/shared/components/fast-ft/_fast-ft.scss - @wheresrhys to migrate away from reliance on nextIcon()

cc @AlbertoElias @onishiweb

bjfletcher commented 8 years ago

@wheresrhys sorry - what exactly do you want me to do here?

wheresrhys commented 8 years ago

The icon you made for gift article needs to go in to o-icons and code in next that uses nextIcon needs to be updated to use o-icons, so a PR to o-icons and then changes in the article app to remove the dependency on nextIcons

bjfletcher commented 8 years ago

@wheresrhys Ok, great. Let's say I have this:

@include nextIcon(arrow-left, getColorFor('link', 'text'), 15);

what should I replace it with?

wheresrhys commented 8 years ago

nothing yet, you need to get the gift icon into the o-icons font set first

bjfletcher commented 8 years ago

Ok, @wheresrhys, is this what you guys wanted?

Gift: https://github.com/Financial-Times/o-ft-icons/blob/master/svg/gift.svg

onishiweb commented 8 years ago

Thanks @bjfletcher, have opened #12 to add the gift icon to the set.

bjfletcher commented 8 years ago

@onishiweb Great, thanks :) Let me know if there's anything more you need from me @wheresrhys :+1:

wheresrhys commented 8 years ago

For the benefit of everyone tagged above, the process should be

Open a PR to submit the SVG[s] of the icon you're using to o-icons
Once that's merged and released replace any uses of nextIcon with something like @include oIconsGetIcon('plus', oColorsGetPaletteColor('cold-1'), 32); - it's an almost identiacl API to nextIcon()

tavvy commented 8 years ago

could someone provide me with permissions for this repo please?

edit: permissions granted. PR opened

wheresrhys commented 8 years ago

The 4th point above (assigned to me) I will raise as an issue in n-ui. It's dependent on fastft being added to the logo-images repo (@aelias is aware of this) but needn't block this issue

AlbertoElias commented 8 years ago

@sarahhornsey is looking into getting the logo

ironsidevsquincy commented 8 years ago

All done, I'll close once the new icon set has been deployed to the image service (should be Monday)