search

Financial-Times / o-icons

Icons for FT sites. http://registry.origami.ft.com/components/o-icons
4 stars 4 forks source link

Update `o-ft-icons` dependents to use `o-icons` #14

Closed onishiweb closed 8 years ago

onishiweb commented 8 years ago

Dependents:

onishiweb commented 8 years ago

o-gallery: https://github.com/Financial-Times/o-gallery/pull/56 o-hierarchical-nav: https://github.com/Financial-Times/o-hierarchical-nav/pull/65

onishiweb commented 8 years ago

o-expander: https://github.com/Financial-Times/o-expander/pull/31

onishiweb commented 8 years ago

o-buttons: https://github.com/Financial-Times/o-buttons/pull/79

onishiweb commented 8 years ago

@wheresrhys once the final PR (for o-buttons) is merged that's all of the Origami components updated to use o-icons, just need whatever's remaining in #11 and then next-sass-setup can be updated which I think is what will mean your switch to o-icons :)

wheresrhys commented 8 years ago

cool. I think, as next-sass-setup only included o-ft-icons in order to switch it off, we can probably remove o-ft-icons as as direct dependency of next/next-sass-setup/n-ui without further work.

Will any/all of your adding of o-icons to the above entail major releases?

onishiweb commented 8 years ago

Yes, most of those additions are major releases sadly, part of the spec is new dependencies require a major version.

wheresrhys commented 8 years ago

Have they already been released? I would say that'd be overzealous application of that rule, which only exists because of the potential of major version clashes. But with o-icons there is only one major version, so no potential for a clash and a failed build service build.

On Wed, 25 May 2016 at 16:46 Adam Onishi notifications@github.com wrote:

Yes, most of those additions are major releases sadly, part of the spec is new dependencies require a major version.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/Financial-Times/o-icons/issues/14#issuecomment-221615297

This email was sent by a company owned by Financial Times Group Limited ("FT Group http://aboutus.ft.com/corporate-information/#axzz3rajCSIAt"), registered office at Number One Southwark Bridge, London SE1 9HL.
Registered in England and Wales with company number 879531. This e-mail may contain confidential information. If you are not the intended recipient, please notify the sender immediately, delete all copies and do not distribute it further. It could also contain personal views which are not necessarily those of the FT Group. We may monitor outgoing or incoming emails as permitted by law.

onishiweb commented 8 years ago

They have. Because of the deprecation of o-ft-icons as well and some of the changes to the API in o-icons this would have needed to be the case anyway.

wheresrhys commented 8 years ago

fair enough. It'll probably be a bit longer though for us to wean ourselves off o-ft-icons

alicebartlett commented 8 years ago

@onishiweb can we close this issue yet?

onishiweb commented 8 years ago

I think it's waiting on @wheresrhys to upgrade Next's stuff away from o-ft-icons's next branch? But in terms of Origami there's nothing much left to do.

wheresrhys commented 8 years ago

that's done. Didn't realise this was still open