search

Financial-Times / o-icons

Icons for FT sites. http://registry.origami.ft.com/components/o-icons
4 stars 4 forks source link

Add o-icon-small-icon classes #143

Closed chee closed 3 years ago

chee commented 3 years ago

I am looking to see how much it would increase the bundle size to close #49

notlee commented 3 years ago

@chee the small modifier is unlikely to capture all cases and could be an unexpected size (big buttons are also 40px high for example). We might want to review common sizes and come up with names that work for those contexts. Or! Depending on who needs this and their support requirements we could support setting the width/height with a single css Custom Property --o-icons-size?

origamiserviceuser commented 3 years ago

o-icons bundle size difference from 6.1.0 to 5163a8599bbdf6ebda46b2cabfd4b8996bcbd1cd css, master: 39.29kb increase (1.05kb/gzip) css, internal: 39.29kb increase (1.05kb/gzip) css, whitelabel: 39.29kb increase (1.05kb/gzip)

chee commented 3 years ago

@chee the small modifier is unlikely to capture all cases and could be an unexpected size (big buttons are also 40px high for example). We might want to review common sizes and come up with names that work for those contexts. Or! Depending on who needs this and their support requirements we could support setting the width/height with a single css Custom Property --o-icons-size?

this was just to find out the bundle size. sorry, i should have marked it as a draft.