search

Financial-Times / o-icons

Icons for FT sites. http://registry.origami.ft.com/components/o-icons
4 stars 4 forks source link

Add apply-width-height param to mixin #9

Closed onishiweb closed 8 years ago

onishiweb commented 8 years ago

Fixes #10

AlbertoElias commented 8 years ago

Uhm, if you set the width variable to null, wouldn't it achieve the same effect? I'm still not saying we shouldn't merge this, as I'm not sure the other option is very user friendly

onishiweb commented 8 years ago

Just tried the calculation on that in Sassmeister and get the error: Invalid null operation: "null plus 0px". The current code only checks for null on the height not the width, so we'd have to do that to get the same result, I think this is possibly the best solution we'll get at the moment

AlbertoElias commented 8 years ago

👍

onishiweb commented 8 years ago

Just rebased the commits.