search

Financial-Times / o-share

URL and social media sharing
http://registry.origami.ft.com/components/o-share
5 stars 6 forks source link

Design appearance #10

Closed manalishi79 closed 10 years ago

manalishi79 commented 10 years ago

A high level design has been planned - which is pending definitive sign off.

In the interim can the background colour currently be removed and link icon placed instead of the envelope graphic.

This is needed for fastFT as it's currently rendering incorrectly.

triblondon commented 10 years ago

We want the background because it groups the buttons together, and allows us to put a single interaction count that aggregates activity across all networks. How would this be done if there were no background?

danskinner commented 10 years ago

I'm still trying to get sign off for this, but we don't necessarily want the count at this stage.

dan-searle commented 10 years ago

The link icon part of this is covered by #4.

manalishi79 commented 10 years ago

Thanks Dan Se. @triblondon The grouping of the icons isn't necessary at the moment coz there are just two. Their proximity and similarity in scale and shape intrinsically show they're "together". Adding background colour in this case would just be a fiddly design faff IMHO.

Sidepoint: Also, we're only supposed to be following ft.com/fastft original implementation.

dan-searle commented 10 years ago

I've removed the background colour and padding now (in 3a7bffe31f46e9ff7e82aa4f16961be9fea89390).