search

Financial-Times / o-tracking

Origami Tracking component
http://registry.origami.ft.com/components/o-tracking
6 stars 8 forks source link

Replace developer mode with test mode and send the event to Spoor with `is_live` set to false. #288

Closed JakeChampion closed 4 years ago

JakeChampion commented 4 years ago

Chris Brown pointed out that is_live currently is not used to filter out test data but that it could be if o-tracking enforced a consistent setting, which is what o-tracking will now do.

origamiserviceuser commented 4 years ago

o-tracking bundle size difference from 2.0.10 to 0785e295dee8fd5bb490350188999a09f1076a2e js: 4.27kb increase (1.33kb/gzip)

origamiserviceuser commented 4 years ago

o-tracking bundle size difference from 2.0.10 to e06cc883c8c22a65ec65cf1ae639c11f7c4d286d js: 4.41kb increase (1.33kb/gzip)

notlee commented 4 years ago

I love that you're taking the opportunity to make low hanging improvments as you go with feedback from the data team :)

origamiserviceuser commented 4 years ago

o-tracking bundle size difference from 2.0.10 to 85580079c68f6cbe67efa89dac31f8c7b4121412 js: 4.41kb increase (1.33kb/gzip)

origamiserviceuser commented 4 years ago

o-tracking bundle size difference from 2.0.10 to 3a3538651dc27f128a5614efb990387958c1b2e4 js: 4.41kb increase (1.33kb/gzip)

origamiserviceuser commented 4 years ago

o-tracking bundle size difference from 2.0.10 to 8511bb79d15d5dc33e52297bc7b2d08321a64aec js: 4.41kb increase (1.33kb/gzip)

origamiserviceuser commented 4 years ago

o-tracking bundle size difference from 2.0.10 to bee7d0990259a7e5a8e2294ed41c3744ee8f3271 js: 4.41kb increase (1.33kb/gzip)