search

Financial-Times / o-tracking

Origami Tracking component
http://registry.origami.ft.com/components/o-tracking
6 stars 8 forks source link

Improve test coverage #327

Closed notlee closed 3 years ago

notlee commented 3 years ago

For example ensure public apis are as expected: https://github.com/Financial-Times/o-tracking/pull/326

chee commented 3 years ago

i've started looking at this, and there appear to be tests that cover this? and they were added in the linked PR @notlee ?

chee commented 3 years ago

the test coverage of o-tracking appears to be very high, and the api mentioned in this issue is now tested thanks to @notlee's PR

notlee commented 3 years ago

Those tests cover internals not the public api. I was thinking some basic checks that oTracking.click.init, and other public functions, actually exist