search

Financial-Times / o-typography

Typography and vertical rhythm styles for FT branding
http://registry.origami.ft.com/components/o-typography
10 stars 2 forks source link

update focus style #132

Closed gvonkoss closed 6 years ago

gvonkoss commented 6 years ago

@lc512k I believe the line that you've pointed out in the issue is for the text color on hover (and on focus), not necessarily the border/outline color for the focus state. I've changed the base color to teal-100 in the custom link mixin.

Closes #131

lc512k commented 6 years ago

@gvonkoss I think both hover and focus feed off the hover color? https://github.com/Financial-Times/o-typography/blob/4586dbf37a099ef498ff73dda6a53fc4d7beef0e/src/scss/use-cases/_general.scss#L29-L30 May have gone down the wrong rabbit hole though :typing-dog:

gvonkoss commented 6 years ago

Yup, they do, but what it looks like you're referencing is the text colour, not the outline of the element. The border-bottom in this case is the styling that indicates the text is a link (which changes colour on hover and disappears on focus). So I've changed the structure a bit to be more explicit about what changes affect which state, is that more legible?

gvonkoss commented 6 years ago

This aligns with the focus styles in o-normalise