Use `text-decoration` for links?

Financial-Times / o-typography

Typography and vertical rhythm styles for FT branding

http://registry.origami.ft.com/components/o-typography

10 stars 2 forks source link

Use `text-decoration` for links? #188

Closed notlee closed 4 years ago

notlee commented 5 years ago

Pro: text-decoration, along with text-decoration-skip-ink, will allow for a space between descenders.

Negative: Our current link underlines have a 2px width and a slight opacity which we would lose. Although it might be possible in the future with text-decoration-width.

Context in Slack: https://financialtimes.slack.com/archives/C02FU5ARJ/p1556891182072800

notlee commented 4 years ago

text-decoration-thickness, text-underline-offset, and text-decoration-skip-ink is now supported by Firefox as of 70.0 🎉 Making it possible to keep the thicker underline.

Safari also supports these.

notlee commented 4 years ago

This will be used in the next major version, to be released as part of the major cascade. See https://github.com/Financial-Times/o-typography/pull/206