Financial-Times / o-typography

Typography and vertical rhythm styles for FT branding
http://registry.origami.ft.com/components/o-typography
10 stars 2 forks source link

Blockquote review #189

Closed notlee closed 5 years ago

notlee commented 5 years ago

o-typography includes a blockquote class for styles without an indent:

Screenshot 2019-05-08 at 14 28 04

However the wrapper class styles child blockqupte elements with an indent:

Screenshot 2019-05-08 at 14 28 16

Further there is an o-quote component, with indent and different colouring, which is used in ft.com articles:

Screenshot 2019-05-08 at 14 28 33

Which is "correct" and which should be deprecated? Keeping in mind uses outside of ft.com, such as within internal products.

notlee commented 5 years ago

This is duplicated by the v6 proposal. We have decided to remove the blockquote styles from o-typography in favour of o-quote