Update `oTypographyLink` and remove other link mixins.

Financial-Times / o-typography

Typography and vertical rhythm styles for FT branding

http://registry.origami.ft.com/components/o-typography

10 stars 2 forks source link

Update `oTypographyLink` and remove other link mixins. #210

Closed notlee closed 5 years ago

notlee commented 5 years ago

Replace the following mixins in favour of oTypographyLink arguments:

oTypographyLinkCustom
oTypographyLinkExternal
oTypographyLinkExternalIcon

See the SassDoc examples for more details.

Relates to the v6 proposal: https://github.com/Financial-Times/o-typography/issues/203

The readme and migration guide will be improved in later commits.

origamiserviceuser commented 5 years ago

o-typography bundle size difference from 5.12.0 to 148e84e1d55084140ad9c7fa116a7f6ba485c568 css, master: 13.86kb decrease (-1.21kb/gzip) css, internal: 9.96kb decrease (-0.64kb/gzip) css, whitelabel: 1.42kb decrease (-0.19kb/gzip) An insignificant difference was also found for: js

origamiserviceuser commented 5 years ago

o-typography bundle size difference from 5.12.0 to 41f338047a65f1df1ad4fbf31f3588aaf95c4699 css, master: 13.75kb decrease (-1.19kb/gzip) css, internal: 9.85kb decrease (-0.62kb/gzip) css, whitelabel: 1.31kb decrease (-0.17kb/gzip) An insignificant difference was also found for: js

origamiserviceuser commented 5 years ago

o-typography bundle size difference from 5.12.0 to 4a19c8c59e028c19f7fdad14fe028fbfc8acb0dd css, master: 13.52kb decrease (-1.08kb/gzip) css, internal: 9.63kb decrease (-0.51kb/gzip) css, whitelabel: 1.09kb decrease (-0.06kb/gzip) An insignificant difference was also found for: js