search

Financial-Times / o-typography

Typography and vertical rhythm styles for FT branding
http://registry.origami.ft.com/components/o-typography
10 stars 2 forks source link

Update the primary mixin to support the output of a single heading. #242

Closed notlee closed 4 years ago

notlee commented 4 years ago

This previously errored:

@include oTypography($opts: (
    'headings': (1)
));

The "headings" option must be a list of heading levels to include e.g. (1, 2, 3, 4, 5).

That's because

$a: type-of((1)) // number
$a: type-of((1,)) // list

https://github.com/Financial-Times/o-typography/issues/241

origamiserviceuser commented 4 years ago

o-typography bundle size difference from 6.1.0 to e3f509d8889918ed43e738011b9f1e094a8a1d3c css, master: 0.21kb increase (0.01kb/gzip) An insignificant difference was also found for: js, css (internal), css (whitelabel)