remove npm dependencies, which are a deviation from the spec :o - Githubissues

Financial-Times / o-typography

Typography and vertical rhythm styles for FT branding

http://registry.origami.ft.com/components/o-typography

10 stars 2 forks source link

remove npm dependencies, which are a deviation from the spec :o #265

Closed chee closed 4 years ago

chee commented 4 years ago

the npm section of the component spec says that components' package.jsons must not include the dependencies property

However, this component does contain npm dependencies: https://github.com/Financial-Times/o-typography/blob/master/package.json#L3-L6

One of these dependencies is also listed in the bower.json: https://github.com/Financial-Times/o-typography/blob/master/bower.json#L14

the other dependency is available in bower... but also it appears not to be used?: https://github.com/Financial-Times/o-typography/pull/115

i think it was missed in PR #115

origamiserviceuser commented 4 years ago

:tada: This PR is included in version v6.3.7 :tada: