Financial-Times / o-typography

Typography and vertical rhythm styles for FT branding
http://registry.origami.ft.com/components/o-typography
10 stars 2 forks source link

Require the latest o-fonts release #307

Closed notlee closed 3 years ago

notlee commented 3 years ago

dotcom-page-kit preloads font files using JS. It needs to match the font files used by o-typography, which we can achieve by requiring the most recent o-fonts version or later. https://github.com/Financial-Times/dotcom-page-kit/pull/826

In the future o-fonts should provide a JS api to get the font url used for preloading. Perhaps in design token form

origamiserviceuser commented 3 years ago

o-typography bundle size difference from 6.4.5 to 528a52d69bbacbe925313256c8cb1ab32fbe4ee7 css, master: 1.34kb increase (0.06kb/gzip) css, internal: 0.32kb increase (0.02kb/gzip) An insignificant difference was also found for: js, css (whitelabel)

origamiserviceuser commented 3 years ago

:tada: This PR is included in version v6.4.6 :tada: