search

Financial-Times / o-viewport

Utility for attaching debounced listeners to resize, scroll and orientation events on window
http://registry.origami.ft.com/components/o-viewport
3 stars 5 forks source link

use pull_request_target and not pull_request for the safe workflows #125

Closed JakeChampion closed 3 years ago

JakeChampion commented 3 years ago

We have workflows that currently fail to run correctly for pull-requests from forks or pull-requests from dependabot. The reason is because those workflows are being triggered by the 'pull_request' event, which does will use a restricted github api token for pull-requests from forks or dependabot for security reasons.

For our workflows which are 'safe' (meaning they do not checkout the code or execute the code in the repository), we can change their trigger from 'pull_request' to 'pull_request_target', which uses a github api token with more permissions, specifically it has permission to read/use secrets, which are the things are workflows require.

Our workflows are safe, they do not checkout or execute the code from the repository, so we should change to using pull_request_target to make our workflows work for dependabot and pull-requests from forks.

origamiserviceuser commented 3 years ago

o-viewport bundle size difference from 4.0.5 to 5e90ec509e9cc912df2287910c625be8866363cd No significant bundle size differences found.

origamiserviceuser commented 3 years ago

o-viewport bundle size difference from 4.0.5 to 7496bcced3a4c4c3c84eedd8dd2cf5c72d9a1fff No significant bundle size differences found.