search

Financial-Times / origami-build-tools

Standard Origami component development tools.
47 stars 15 forks source link

JSHint warnings don't fail build on OBT #158

Closed matthew-andrews closed 9 years ago

matthew-andrews commented 9 years ago

https://travis-ci.org/Financial-Times/origami-build-tools/builds/43842714

AlbertoElias commented 9 years ago

Yup, this is fixed in the testing branch, I don't know if I have pushed it yet. I expect the branch to be merged into master next week.

matthew-andrews commented 9 years ago

:-) sweeeet

wheresrhys commented 9 years ago

ft-api-client is failing like nobody's business, so I guess it's merged

AlbertoElias commented 9 years ago

@wheresrhys Not yet actually #184

wheresrhys commented 9 years ago

ah, I think it must be lintspaces then

matthew-andrews commented 9 years ago

i think this is fixed now?

robin-marr-ft commented 9 years ago

Yep, the fail reporter has been added so it should kill builds now.

On 29 January 2015 at 14:07, Matt Andrews notifications@github.com wrote:

i think this is fixed now?

— Reply to this email directly or view it on GitHub https://github.com/Financial-Times/origami-build-tools/issues/158#issuecomment-72029901 .

This email was sent by a company owned by Pearson plc, registered office at 80 Strand, London WC2R 0RL. Registered in England and Wales with company number 53723.

AlbertoElias commented 9 years ago

Yup :) Lintspaces doesn't fail build though, the module doesn't implement it