search

Financial-Times / origami-image-service

Optimises and resizes images
https://www.ft.com/__origami/service/image
0 stars 0 forks source link

Decommision the blogs domain workaround once the blogs.ft.com domain is decommissioned #642

Open JakeChampion opened 4 years ago

JakeChampion commented 4 years ago

What

We have a workaround to make old blog images work: https://github.com/Financial-Times/origami-image-service/pull/641/

When requests to those old blog images no longer occur, let's remove this workaround.

Details

When the splunk search returns less than 100 results (ideally 0) we should delete the code which makes the old blog images work. We already have an alert setup in Splunk to email us when the request count drops below 100 for these images.

Here is the splunk search we use:

index=restricted_ftdotcom source=133g5bgac00hv4v8t0dmry request.path="/__origami/service/image/v2/images/*" request.path="*blogs.r.ftdata.co.uk*" request.referrer="http*" | table request.referrer | sort request.referrer | uniq request.referrer

Splunk alert -- Likely only Jake can see this.

JakeChampion commented 4 years ago

We've brought the broken images to the attention of the team who are going to do the blogs migration work (that migration may never happen) -- https://financialtimes.slack.com/archives/CSH1XFM5W/p1600699666005300?thread_ts=1600699202.004400&cid=CSH1XFM5W

notlee commented 4 years ago

This is great, thanks :)

Likely only Jake can see this [Splunk alert].

Can confirm!

You do not have permissions to access objects of user=jake.champion@ft.com

Although you can update the permission from the alert dashboard

JakeChampion commented 4 years ago

This is great, thanks :)

Likely only Jake can see this [Splunk alert].

Can confirm!

You do not have permissions to access objects of user=jake.champion@ft.com

Although you can update the permission from the alert dashboard

Can you try again now please? I think I updated the permissions this time.

notlee commented 4 years ago

Looks like not :( for the Bundle Build Error - Origami Build Service alert I can edit permissions via the alert dashboard. It's set to "Display for: App" and given user read/write which I think means anyone who can login can see

JakeChampion commented 4 years ago

Hmm I had it set to read for user. I've now set it to write for user as well, hopefully that works

notlee commented 4 years ago

The link above doesn't work but I can get to it from the alerts page 👍 likely it worked before but I didn't find it on the alerts page. I did a cmd+f to find it, not realising the list of alerts is paginated 🙈 it's good that another team member can edit it though anyhow :)

chee commented 3 years ago

i just performed this search and it said 23 results in the last day